-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Protocol] Centralized Proof & Tokenomics param updating #486
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
…am_name param_bz --response params
57e723b
to
a273519
Compare
… name as_type --response params
a273519
to
b7a04d7
Compare
…cept * pokt/main: [CI] Release artifacts job: binaries and containers (#523)
tempFile, err := os.CreateTemp("", "exec.json") | ||
require.NoError(s, err) | ||
|
||
defer func(f *os.File) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it possible to just call defer tempFile.Close()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is but once we turn on more linters, one should complain about the ignored error return from #Close()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- A couple small comments from me
- In support of the other comments left
- Pre-emtively approving so we can get this in!
e2e/tests/update_params_test.go
Outdated
// ensureOnChainAccount sends a minimal amount of upokt tokens to the given address | ||
// to ensure it has an on-chain account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// ensureOnChainAccount sends a minimal amount of upokt tokens to the given address | |
// to ensure it has an on-chain account. | |
// ensureOnChainAccount sends a minimal amount of upokt tokens to the given address | |
// to ensure it has an on-chain account. This means that the public key is retrievable when | |
// queried for by address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that the public key is retrievable when queried for by address.
I don't believe that this is accurate. Funding the address ensures that it has a balance in the bank module; however, it doesn't have any effect on the auth module AFAIK, which is where the public key is stored. My understanding is that a tx would have to be submitted which was signed by that key in order to get the public key on-chain. While funding the address is a prerequisite for this, they are distinct steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…cept * pokt/main: [Documentation] Improve RelayMiner staking related documentation (#524) A couple comment improvements Update google drive video to youtube video
Co-authored-by: Redouane Lakrache <[email protected]>
TODO:
|
(cherry picked from commit efaaad6f33b1645b5fe742dc6ce82392de76dc92)
Summary
MsgUpdateParam
message type & handler to tokenomics & proof modules for updating individual params.See: #322 & "governance schemes" in notion - Gov Prams.
Changes
update_tokenomics_params_all
update_tokenomics_param_compute_units_to_tokens_mulitplier
update_proof_params_all
update_proof_param_min_relay_difficulty_bits
MsgUpdateParam
message to both tokenomics & proof modules for updating an individual param by nameDemo
authz_gov.webm
Issue
Type of change
Select one or more:
Testing
Documentation changes (only if making doc changes)
make docusaurus_start
; only needed if you make doc changesLocal Testing (only if making code changes)
make go_develop_and_test
make test_e2e
PR Testing (only if making code changes)
devnet-test-e2e
label to the PR.make trigger_ci
if you want to re-trigger tests without any code changesSanity Checklist